Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This core is now not required #122

Open
andres-asm opened this issue Mar 22, 2019 · 8 comments
Open

This core is now not required #122

andres-asm opened this issue Mar 22, 2019 · 8 comments

Comments

@andres-asm
Copy link
Contributor

I have added the "sdl removing" stuff to my core (optional) thanks to @M4WX, and now the core works even on WiiU and Switch (tested).

It also compiled for emscripten but that needs someone to update the html so it can load the core.
That makes this core effectively pointless.

I'd be willing to fix build errors for SVN if there are any. I sent PRs to enable it for WiiU and Vita.
Also I benchmarked SVN and this with X86_64 and dynrec and cycles MAX for some reason SVN is able to kick the cycles automatically and this one isnt:

SVN
image

This
image

I'd prefer if this core was deprecated so I don't have to keep them in-sync.

@andres-asm
Copy link
Contributor Author

To build with fake SDL just do WITH_FAKE_SDL=1

@andres-asm
Copy link
Contributor Author

It builds and loads for emscripten too
image

Though it crashes:

image

Not sure how to fix that anyway, that's an issue for another day

@andres-asm
Copy link
Contributor Author

@ehmry
Copy link
Contributor

ehmry commented Mar 25, 2019

What is the difference between https://github.com/libretro/dosbox-libretro and https://github.com/fr500/dosbox-svn?

@stellarporter
Copy link

https://github.com/libretro/dosbox-libretro seems outdated enough with official svn but supports genode, and maybe has a few QoL tweaks not in fr500 fork. Libretro side possibly uses some stale code from initial porting days, that could make it harder to add things.

https://github.com/fr500/dosbox-svn is constantly up-to-date with upstream fixes and supports most major platforms. Looks to support extra Dosbox features like variable refresh rates. Libretro side is rebuilt and better structured for future things. Check the libretro branch. This one is a winner.

@andres-asm
Copy link
Contributor Author

I can backport any makefile changes and I'd be willing to accept PRs to genode or whtever.

I don't think there is anything in the old port that I don't support.

@ehmry
Copy link
Contributor

ehmry commented Mar 29, 2019

Ok, maybe this weekend I will transition.

@Gagert
Copy link

Gagert commented Oct 23, 2019

The links seem outdated for this newer DOSBox SVN libretro core (got me confused initially).

https://github.com/libretro/dosbox-svn/tree/libretro this is the new link for those who do not know (the libretro branch of dosbox-svn, defaults to the non-libretro master branch while entering dosbox-svn from a search engine/github search and such).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants