Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"NEC - PC Engine SuperGrafx" and "Microsoft - MSX2" typo in no-intro DAT-o-MATIC #73

Closed
sergiobenrocha2 opened this issue Jan 17, 2016 · 18 comments

Comments

@sergiobenrocha2
Copy link
Contributor

Creating this issue just to reminder that NEC - PC Engine SuperGrafx has a typo in the no-intro dat

http://datomatic.no-intro.org/index.php?page=forum&op=browse&thread=2317

https://en.wikipedia.org/wiki/PC_Engine_SuperGrafx

Please don't mess with these files... you change the name in one file it must be changed in another 6 different places... I fixed that 6 months ago...

@sergiobenrocha2
Copy link
Contributor Author

@sergiobenrocha2 sergiobenrocha2 changed the title NEC - PC Engine SuperGrafx "NEC - PC Engine SuperGrafx" and "Microsoft - MSX2" typo in no-intro DAT-o-MATIC Jan 17, 2016
@RobLoach
Copy link
Member

We should go with what No-Intro provides, and push that change upstream to No-Intro if possible. Their forums might be a good place to start that discussion.

@sergiobenrocha2
Copy link
Contributor Author

I reported it but nobody answers...

@kivutar
Copy link
Member

kivutar commented Feb 27, 2016

Have you tried reported it on their forums instead of their website? I think you would get a reply.

I got some users wanting to contribute and they were confused about this change we made. It's natural for users to think that no-intro is right (while they are wrong in this case).

So I would also prefer if we stick with what no-intro use and ask them to fix it on their side. I registered on their forums and I'm waiting for the confirmation of my account.

@lollo78
Copy link
Contributor

lollo78 commented Feb 27, 2016

Hi guys, I'm registered on their forum: http://forums.no-intro.org.
I did it some months ago, but I never posted nothing until now.
If I remeber well, it's a long procedure: they manually approve all the new subscriptions after analyzing the motivations of the applicant.
So, if you tell me exatcly what I have to ask, and you give me the authorization to speak for the Libretro Team, I can post quickly a request for you.

I noticed the typo inside SuperGrafx .dat (they write "NEC - Super Grafx" instead of "NEC - PC Engine SuperGrafx"), but I'm not sure about the typo for MSX 2: they write "Microsoft - MSX 2" instead "Microsoft - MSX2? So we ask to remove only the space between MSX and 2, right?

@kivutar
Copy link
Member

kivutar commented Apr 14, 2016

Looks like their forum are down now.

@RobLoach
Copy link
Member

RobLoach commented Jul 5, 2016

I suggest closing this. We roll with what No-Intro gives us.

@kivutar
Copy link
Member

kivutar commented Jul 5, 2016

I agree with you, but @sergiobenrocha2 doesn't agree

@RobLoach
Copy link
Member

RobLoach commented Jul 5, 2016

The entries may be passed through translation in RetroArch. It may be possible to translate to the "correct" spelling in the frontend, while keeping them No-Intro-style internally.

@sergiobenrocha2
Copy link
Contributor Author

No, please don't do that, we'll have to change back stuff from dozen places. I can update these databases this week.

@kivutar
Copy link
Member

kivutar commented Jul 5, 2016

This change have been the source of a lot of bugs in the past. Some of these bugs are still present, like we still serve two thumbnail packs. We should never have changed it in the first place without upstreaming it first.

Now what is done is done and going back could take a lot of time.

I'm still in favor of going back, because conforming to no-intro makes our resources usable by other projects outside of the libretro scope.

@twinaphex were also in favor of rolling back that change the last time we discussed it on IRC.

So I think you're the only one in the team wanting to keep the right name @sergiobenrocha2

@sergiobenrocha2
Copy link
Contributor Author

Then next month they fix it, and we have to change back again. Good luck.

@kivutar
Copy link
Member

kivutar commented Jul 5, 2016

Yeah... That's a possibility. I posted on their forums some weeks ago and they did nothing. Why is it so difficult to join these people?

BTW, their forum are down :(

@sergiobenrocha2
Copy link
Contributor Author

sergiobenrocha2 commented Aug 21, 2016

I was going to update MSX2 dat, and for my surprise its last update was 2015-08-03. So do we really need to move from "MSX2" to "MSX 2" ? I thought this thing was update monthly...

@RobLoach
Copy link
Member

RobLoach commented Aug 22, 2016

I thought this thing was update monthly...

It happens whenever someone updates it.

BTW, their forum are down :(

No longer http://forums.no-intro.org/

@RobLoach
Copy link
Member

Going to close this for now. I see the discussion topics you started up. Let's continue talks there.

@sergiobenrocha2
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants