Bodyslam missing graphics #1368
Comments
|
Changing the sprite system shows that the sprites are actually there lol. |
|
@MistyDreams can you test this with the new video code? Might be the issue. |
|
@mahoneyt944 you can use the code anytime its from a newer mame just a few banking niggles i want to work out for afighters. I wouldnt recommend this in master atm though really up to you guys though |
|
Just pulled it into a branch called Mist for testing. |
|
works fine on mine had a look bankswitch isint working i fixed it on mine a while back MistyDreams@33be925 |
|
Just tried this, it didn't fix the issue, bodyslam isn't setting a obj_bank either. |
|
work fine on my port no idea why maybe something else else has changed |
|
Idk something simple I'm sure but don't see it. |
|
I updated to the latest masteri n my branch compiled it and it works fine |
|
Wtf? With no changes? |
|
yeap fine with no changes did you verify your roms i done a clean compile as well. Doesnt take long to compile this core
|
|
It's the titlescreen where they don't work. And that weird big rope bug on the back left of the ring |
|
I dont have any glitches it the title screen is blank |
|
Where it says coin insert |
|
See the first post |
|
yea its missing here but no corruption though :) |
|
Yeah there's no corruption here either, it gets the corruption effect if you change the sprite system, but by doing this shows that the tiles are there. |
|
well there is no updateproc nevermind i seen it. leave that in the todo list think its system16a not touched that one. I do have the code in my branch not tested it yet though you can take it for a wee spin if you want. Will need to fix something up first though though |
|
I was going to do this at the weekend but i done it now tested and the it fixes the issue |
|
ps that copyright warning is only meant to show the first time you load a game not every time! |
|
There's a core option to disable the copyright warning. Shouldn't show at all if disabled. |
|
I should get this afigher issue fixed this weekend. Its most likely some kind of banking issue cause the code clamps it |
|
im going to delete my opaopa branch soon if you want to grab the fixes for this before i do feel free. you just need to copy sys16a draw sprite and hookit it up. the macro helpers are added in src/common.h |
|
I can't recall where we were with this to be honest, I'm currently in the middle of closing on a new house. Not sure when I'll have time to look back. |
|
well ill leave the branch open for now till you have time no rush was just cleaning up |
|
Do we want to just create the segas16a driver and video driver instead? Seems you already had the vidhrdw ported. There's not that many games anyway. Plus I'd like to slowly obsolete the system16 driver in favor of the new one. Thoughts? |
|
nothing to port will just drop in just need to hook it up to drivers properly. just make a skelton segas16a.c and hook up what you need too, grab it from mame090 in historic-mame. |
|
@MistyDreams ok, had a chance to look through this using the old code and the issue is with the sprite priority. Mame2000 uses variable https://github.com/libretro/mame2003-plus-libretro/compare/Test |
|
use this as a reference also in afighter the boat should go under the road bridges in attract mode sequence hardly a game stopping thing though |
|
Since you can drop in segas16a sprite code or just straight up moved to the segas16a code to fix any tile issues as well. I Dont understand why your trying to patch this like this, but if thats the route you want to take who am i to argue. |
|
I realize the newer sprite code is probably the better solution and I'll be adding that in shortly. I was just curious to the regressions and where things went wrong so long ago. tinkering for fun. |
|
Well funny enough, patching the old sprite code vs the new segas16a sprite code both have this same glitch on the title screen. When she swings, there's a bar of pixels under her arm with some issues....Not sure why. Maybe priority related? |
|
what glitch is that the counter being missing ? |
|
Not sure what you're mean about the counter. I'm talking about the title screen under the arm when she swings. |
|
Trying mjleague with the new code, this also has minor issues (so did the old). see the lower corners, the layers aren't in line or something and you get the bars where the background shines through. Most noticable over the green grass. 1 bar above "WT" and 2 bars by the strike count. |
|
well youll need to tweak the priorites |
|
comment out // sys16_bg_priority_value=0x0e00; in bodyslam should fix it |
|
Btw, I'm not knocking the code, just documenting issues as I find them so I don't forget. Lol |
I'll try |
|
add sys16_bg_priority_mode = 2; |
|
Well while that does improve the title screen, it's messes up other priorities. When you get tossed out of the ring your player shows through the health bars |
|
and this is the problem with this video system it can be fixed though youll just need to put the work in or use one that works. youll need to debug the tilemap transparency's |
|
I personally think your obsession with fixing this old video code will get you grey hair but in fairness tinker away you will get there. |
|
I'm trying the newer sprite code but I'm not seeing any improvement over just tweaking the old stuff in regards to bodyslam and mjleague. Maybe these things would be fixed if I used all of the newer vidhrdw from segas16a, but I just don't have the time to do it myself right now and test it properly. |
|
mjleague issue is seems to be a y alignment, you can see the right side of the letters where it's split, if it were up a row of pixels it would line up correctly. |
|
if you go into this level of pickiness youll find faults with most games in this ole driver |
|
I don't see it as picky to identify issues and see if they have easy solutions.....isn't that the whole point? Idk... I'm just going to tweak the old code to fix this issue with bodyslam and leave it open for someone else to take it further if they wish. |
|
Just tried current mame, these shadows behind the health bar are present there too. But should they be? Setting fg priority mode 2 prevents the shadows. So we have to decide if we want the shadow or not?
|
|
try fbneo if unsure its anyones guess I assumed you knew it was wrong. Maybe try find some real arcade footage |
|
just compiled the latest master sprites are still missing from the title screen |
|
ah never mind master was behind n mine. Im going to stop working on this segas16a till thing quite down here sick of rebasing haha |
|
Oh good 😂 thought there was something else still missing lol. Besides the shadow thing to determine, this game looks good to me now. I think the only true way to know is actual arcade footage but who knows if that's out in the wild or not. The only other thing I noticed was, in current mame, there's a "curtain raise" effect before the start of the round. Ours just goes right to the match. The effect doesn't look natural to me so I need to see if this effect is suppose to happen or not. I'm guessing it's a y scroll hookup. If it's supposed to do it. |
|
Just tried fbn and there's no shadows, while current mame has shadows. So it's anyone's guess. I think no shadows seems right but idk, no need to worry about that one. For the curtain thing we are missing it. Probably the yscroll hookup. Here's a pic in the middle of it raising. |
|
its probably the 8751 protection needing done proper like the counter screen being missing too quartet does the same |
|
there also priority issues i afighter you might want to look at if you want to fix things, I personal dont feel they are game breaking anyway |
|
its also might be worth closing threads for each game and make one system16 bugs thread people can just add to the list that way. |
Missing player tiles possibly more, working in mame2000. Looks like the spritesystem is wrong and possibly some of the other configs in the machine driver
Mame2000
Mame2003-plus
The text was updated successfully, but these errors were encountered: