Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Support Changes #18

Closed
ghost opened this issue Mar 26, 2018 · 32 comments
Closed

Sample Support Changes #18

ghost opened this issue Mar 26, 2018 · 32 comments

Comments

@ghost
Copy link

ghost commented Mar 26, 2018

The following samples have been updated to support new and improved versions these
will replace the existing samples from mame2003 and can easily be found via Twistys MAME
samples site.

dkong
dkongjr
vanguard

These ones are new to this core and not supported in mame2003 again they can be
grabbed via Twistys site

cosmica
fantasy
sasuke

@ghost

This comment was marked as spam.

@Wilstorm
Copy link
Contributor

Wilstorm commented Apr 6, 2018

Hey Arcadez I was going to let you know that a few sounds are missing when using samples that I found.

•Depth Charge - no sound
•Donkey Kong - half sound, missing several pieces
•Zaxxon - no sound

Depth Charge and Zaxxon aren't enhanced but just regular samples. Donkey Kong seems to missing sounds looking at the DAT.

sample name="run01.wav"/>
sample name="run02.wav"/>
sample name="run03.wav"/>
sample name="jump.wav"/>
sample name="dkstomp.wav"/>

What is missing is effect00.wav, effect01.wav and effect02.wav which are needed.

@ghost

This comment was marked as spam.

@Wilstorm
Copy link
Contributor

Wilstorm commented Apr 6, 2018

I can't verify right now but I thought the effect wav's where for the girder stomp in the intro, etc. I can test it again around noon.

@ghost

This comment was marked as spam.

@Wilstorm
Copy link
Contributor

Wilstorm commented Apr 6, 2018

Thanks Arcadez, I think so so you back ported them and the sample names changed but effects are the same? I could have sworn I was not getting the girder stomp sound and the running sounds yesterday but I will test again around noon.

@ghost

This comment was marked as spam.

@Wilstorm
Copy link
Contributor

Wilstorm commented Apr 6, 2018

Setup is a breeze and the docs are great. If you skip all the shaders and extra config steps you really only need to know one thing. Where are the samples and ROMs folder and copy them over. I definitely don't know the development side but if there's anything I can do on the setup side just let me know. I think Mark and Grant know both sides. I will verify the samples for sure here in a few hours. Some times I jump in and out of games quickly when testing and miss things.

@ghost
Copy link
Author

ghost commented Apr 6, 2018

I've been following the Retropie thread on this and as @maxbeanz has said, no samples work (on RPi) in 2003plus.

@Wilstorm
Copy link
Contributor

Wilstorm commented Apr 6, 2018

It does look like no samples work. If the audio comes from the ROM set itself it does indeed work but not from the samples. For example dkong the music and barrel smash are fine but the girder stomp, running or jumping do not. I tested this for several ROMs and it seems consistent with samples.

@ghost

This comment was marked as spam.

@ghost

This comment was marked as spam.

@markwkidd
Copy link
Collaborator

markwkidd commented Apr 9, 2018 via email

@Wilstorm
Copy link
Contributor

Wilstorm commented Apr 9, 2018

Daft question time you do have the sample paths setup for mame2003-plus and the sample in
the correct folder eg.......... /libretro system dir/mame2003-plus/samples/

That might not be so daft. I actually have my samples in /home/pi/RetroPie/BIOS/mame2003-plus/samples. It's the same location lr-mame2003 uses so I copied them there. Wrong location? If that's the case we (Max, Zuppa and I) all assumed the wrong location. I can test this at noon-ish as I have a monitor right now but no speakers.

Also samples are/were enabled in the core options I checked that last week.

@Wilstorm
Copy link
Contributor

Wilstorm commented Apr 9, 2018

where is the /libretro system directory = /opt/retropie/configs/arcade/samples or /home/pi/RetroPie/roms/arcade/mame2003-plus/samples

@ghost
Copy link
Author

ghost commented Apr 9, 2018

My samples are also in /home/pi/RetroPie/BIOS/mame2003-plus/samples/ and ON in RetroArch.

@ghost

This comment was marked as spam.

@ghost
Copy link
Author

ghost commented Apr 9, 2018

I tried renaming the directory to

/home/pi/RetroPie/BIOS/mame2003/samples/

Unfortunately still no samples. When running a game it automatically creates another mame2003-plus directory.

@Wilstorm
Copy link
Contributor

Wilstorm commented Apr 9, 2018

These directories did not work:

/opt/retropie/configs/mame-libretro/samples
/home/pi/RetroPie/roms/mame-libretro/samples

/opt/retropie/configs/arcade/samples
/home/pi/RetroPie/roms/arcade/samples

I already have all the samples in this directory and they do work fine for lr-mame2003 when using the Arcade folder but I don't get sound in mame2003_plus_libretro:

/home/pi/RetroPie/BIOS/mame2003/samples

@Wilstorm
Copy link
Contributor

Wilstorm commented Apr 9, 2018

Updated above comment to exclude to more directories:

/opt/retropie/configs/mame-libretro/samples
/home/pi/RetroPie/roms/mame-libretro/samples

@ghost
Copy link
Author

ghost commented Apr 9, 2018

@Arcadez @markwkidd OK guys, i've cracked it !! If you put the samples in the mame2003-plus directory they work ! They don't work inside the samples directory.

@ghost

This comment was marked as spam.

@markwkidd
Copy link
Collaborator

markwkidd commented Apr 9, 2018 via email

@ghost
Copy link
Author

ghost commented Apr 9, 2018

I don't really have a log, nothing was reported. To confirm, the samples work in

/home/pi/RetroPie/BIOS/mame2003-plus/

(/libretro system dir/mame2003-plus/)

@markwkidd
Copy link
Collaborator

markwkidd commented Apr 9, 2018 via email

@Wilstorm
Copy link
Contributor

Wilstorm commented Apr 9, 2018

Any chance to move it into the folder? If I am understanding that correctly they have to be dumped in the folder along with cheat.dat, hiscore.dat, mame2003.xml, etc. instead of using the samples folder?

@Wilstorm
Copy link
Contributor

I can confirm also samples do work directly in the mame2003-plus folder vs. the samples folder. Is it a simple path change to get them back together in a sub folder or more complicated?

@markwkidd
Copy link
Collaborator

markwkidd commented Apr 10, 2018 via email

@Wilstorm
Copy link
Contributor

Sounds perfect, thanks Mark! :)

@markwkidd
Copy link
Collaborator

Hello samples testers. Could you rebuild from the latest source and try out samples again?

@markwkidd
Copy link
Collaborator

@Arcadez what do you think about closing this issue down now?

@ghost
Copy link
Author

ghost commented Apr 18, 2018

As no-one else is bothering, I can confirm that Samples are now working in the correct samples folder.

@ghost ghost closed this as completed Apr 18, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants