Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datafile non compliant #681

Closed
ebolefeysot opened this issue Mar 6, 2019 · 3 comments
Closed

Datafile non compliant #681

ebolefeysot opened this issue Mar 6, 2019 · 3 comments

Comments

@ebolefeysot
Copy link

Hello
I'm the developer of romcenter and @markwkidd submit an issue about loading mame2003plus datafile (https://bitbucket.org/ebolefeysot/romcenter/issues/128/mame-2003-plus-libretro-core-xml-error).

According to the dtd included in the dat header, the tag is defined like this:

    <!ELEMENT driver EMPTY>
        <!ATTLIST driver status (good|preliminary|test) #REQUIRED>
        <!ATTLIST driver color (good|imperfect|preliminary) #REQUIRED>
        <!ATTLIST driver sound (good|imperfect|preliminary) #REQUIRED>
        <!ATTLIST driver palettesize CDATA #REQUIRED>

In the datafile, we find:
<driver>puckman</driver>
and then later in the same game section
<driver status="good" color="good" sound="good" palettesize="16"/>
The 'driver' tag appears two times. The first tag is not compliant.
In my opinion, it should be removed, as there is no definition in the dtd for 'sourcefile' data.

@ghost

This comment was marked as spam.

@ebolefeysot
Copy link
Author

Yes, it's loading.
Thanks.
ps: I have fixed that case in the final release of romcenter anyway.

@markwkidd
Copy link
Collaborator

Thank you both. I have just removed those two lines in info.c for both MAME 2003 and MAME 2003-Plus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants