Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorConfig support or not? #16278

Closed
kokoko3k opened this issue Feb 23, 2024 · 2 comments
Closed

EditorConfig support or not? #16278

kokoko3k opened this issue Feb 23, 2024 · 2 comments

Comments

@kokoko3k
Copy link

85dbd1d

My editor keep stripping trailing white spaces because it correctly supports this configuration.
However not all "committers" editors support this and the code has trailing white spaces here and there, so often my commits ends up stripping trailing white spaces making the commit itself difficult to read.

How should this be handled?

Strip trailing white spaces once for all from all cpp/cxx/h files?
Delete EditorConfig file from retroarch tree?
Remove trim_trailing_whitespace = true from it?
Ideas?

@zoltanvb
Copy link
Contributor

zoltanvb commented Mar 2, 2024

Quick check, about 20% of .c files and 10% of .h files (outside of deps/) seems to have trailing whitespace. But some are not really touched.
My 2c: keep the setting, and maybe do one separate update for the files you are modifying / planning to modify.

@RobLoach
Copy link
Member

While it can be annoying, feel free to submit pull requests with the whitespace changes included. We're not that strict on changesets. GitHub also provides a "ignore whitespace" option when reviewing PRs.

While it does add noise to the diff, cleaning up the whitespace is always appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants