onset and chroma do not use kwarg-getting #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm 👍🏻 |
lostanlen
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #989
What does this implement/fix? Explain your changes.
This PR promotes spectrogram parameters in
onsetmodule to function-level parameters, rather than being pulled out ofkwargs.Similarly,
n_chromais now a proper argument tofeature.chroma_stft.This should resolve issues related to preset-overrides for default parameters.
The documentation has been updated accordingly. These changes do not constitute a substantial change to the API, though some keyword parameter orderings have shifted.