Reassignment docstring typos

[scjs]

Reference Issue

PR #1038

What does this implement/fix? Explain your changes.

Fixes typo: S_df to S_dh, and adds some missing periods. I also moved the reassigned_spectrogram argument recommendations to Notes in a separate commit.

Any other comments?

It looks like Notes is so far just used for notes about caching, so feel free to revert that commit if you prefer.

[bmcfee]

LGTM -- thanks for this! No problem with the notes section, your changes here seem appropriate.

Is there anything else to do here, or shall I merge?

[scjs]

I ran pep8 and fixed some lint in the docstring, and made the S notation consistent. Go ahead and merge if it looks fine to you. Thanks!

[lostanlen]

Thank you for the update, especially for the very eloquent Notes section. This makes me believe that perhaps we should change the pad_mode default?

Also, this problem seems like a big enough a deal to add a line about it in the list of input arguments (at the center), and refer to Notes for the whole spiel explaining the issue.

[bmcfee]

This makes me believe that perhaps we should change the pad_mode default?

I still disagree -- we've been over this before in the original PR, but it's more important to have API consistency on this so that frame alignment across methods is preserved by default.

[bmcfee]

thanks again @scjs !