Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup.py (joblib>=0.14) for python 3.82 #1091

Closed
wants to merge 1 commit into from
Closed

Update setup.py (joblib>=0.14) for python 3.82 #1091

wants to merge 1 commit into from

Conversation

thorwhalen
Copy link

Updating requirement to 'joblib >= 0.14' since joblib 0.12 produces a TypeError (on iOS 10.14.6, with python 3.82 at least). See issue.

Reference Issue

What does this implement/fix? Explain your changes.

Any other comments?

@thorwhalen
Update setup.py
a2c61c9 
Updating requirement to 'joblib >= 0.14' since `joblib 0.12` produces a `TypeError` (on `iOS 10.14.6`, with `python 3.82` at least). See [issue](librosa#1090).
@thorwhalen thorwhalen mentioned this pull request Mar 30, 2020
Closed
@bmcfee
Copy link
Member

bmcfee commented Mar 30, 2020

Thanks for starting this PR.

Right now, your change will not be adequately tested because we don't have a 3.8 environment in the travis build matrix. Would you be able to add that to this PR?

@bmcfee bmcfee added this to the 0.8.0 milestone Mar 30, 2020
@bmcfee bmcfee added management Project governance, packaging, distribution, etc testing Issues with our test design and continuous integration services Upstream/dependency bug Another package is causing us trouble! labels Mar 30, 2020
@bmcfee bmcfee self-requested a review March 30, 2020 14:20
@lostanlen
Copy link
Contributor

Thank you @thorwhalen !
Supporting py38 in the next librosa would be great.
I agree with @bmcfee, we need a py38 test. Please add an entry here: https://github.com/librosa/librosa/blob/master/.travis.yml#L11

@bmcfee bmcfee linked an issue May 5, 2020 that may be closed by this pull request
Update requirements: librosa==0.7.2 does not work with joblib==0.12.2 #1090
Closed
@bmcfee
Copy link
Member

bmcfee commented May 5, 2020

I'm going to roll this change into a bigger update to setup.py and travis configs. (You'll still get credit in the contributing authors doc though!)

@bmcfee
Copy link
Member

bmcfee commented May 5, 2020

This PR is superseded by #1110 . Thanks for doing it though!

@bmcfee bmcfee closed this May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmcfee bmcfee Awaiting requested review from bmcfee

Assignees

@thorwhalen thorwhalen

Labels
management Project governance, packaging, distribution, etc testing Issues with our test design and continuous integration services Upstream/dependency bug Another package is causing us trouble!
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

Update requirements: librosa==0.7.2 does not work with joblib==0.12.2
3 participants
@thorwhalen @bmcfee @lostanlen