New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support pooch >= 1.7 #1727
support pooch >= 1.7 #1727
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1727 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 34 34
Lines 4587 4587
=======================================
Hits 4530 4530
Misses 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Aha... this is going to be a pain for the historical documentation build. I'll have to rethink this... |
Two ideas here:
|
I've updated the librosa data repo to move the offending filenames, but add backward-compatible symbolic links so that old versions continue to work. I think this ought to do the trick. |
Reference Issue
Fixes #1688
What does this implement/fix? Explain your changes.
This PR rewrites the example data registry file to use the new format introduced in pooch 1.7.0.
It removes the upper pin on the pooch dependency, and bumps our minimum supported version to 1.7.
Any other comments?
Per my comments in #1688, I'm still ambivalent on this, as it would force an update to user environments that is not backward-compatible. But, since it's extremely unlikely to affect anyone, I'm leaning toward rolling it into 0.10.1 anyway.
No functionality changes here, so as long as the CI passes and builds cleanly, it should be good to merge.