Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate FeatureExtractor #282

Closed
bmcfee opened this issue Nov 23, 2015 · 2 comments
Closed

Deprecate FeatureExtractor #282

bmcfee opened this issue Nov 23, 2015 · 2 comments
Assignees
@bmcfee
Labels
API change Does this change the behavior of existing API? functionality Does this add new functionality?
Milestone
0.4.2

Comments

@bmcfee
Copy link
Member

bmcfee commented Nov 23, 2015

Deprecate in 0.4.2, remove in 0.5.0.

Sklearn now provides this for us, although the API isn't quite as functional in that you can't store (keyword) arguments within the object.
@bmcfee bmcfee added functionality Does this add new functionality? API change Does this change the behavior of existing API? labels Nov 23, 2015
@bmcfee bmcfee self-assigned this Nov 23, 2015
@bmcfee bmcfee added this to the 0.4.2 milestone Nov 23, 2015
@bmcfee
Copy link
Member Author

bmcfee commented Dec 20, 2015

The sklearn implementation now supports everything that we had here, so this issue is no longer blocked.

@bmcfee bmcfee mentioned this issue Jan 4, 2016
Merged
@bmcfee
Copy link
Member Author

bmcfee commented Jan 4, 2016

resolved by merging #294

@bmcfee bmcfee closed this as completed Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmcfee bmcfee

Labels
API change Does this change the behavior of existing API? functionality Does this add new functionality?
Milestone
0.4.2
Development

No branches or pull requests
1 participant
@bmcfee