Cache refactor #829
Merged
Cache refactor #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmcfee
commented
Feb 20, 2019
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #795
What does this implement/fix? Explain your changes.
This PR restructures the cache class (and submodule) in two ways:
cachemodule has been moved to_cache, and the singleton object no longer overrides the module in the system namespace.cacheclass no longer extends fromjoblib.Memory, which should save us from future API compatibility issues like joblib 0.12 causes TypeError at import #729Any other comments?
This should have no apparent effects to 99% of users. The only users who may experience problems are those who depend on
librosa.cachebeing an instance ofjoblib.Memory; in those cases, the memory object can be accessed directly bylibrosa.cache.memory.I've tested locally, and all the timing examples from the documentation still work as expected. As long as CI passes, I see no need for CR.
This change is