fixed #827 by limiting width to at most the length of the data in rec… #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrence_matrix
bmcfee
added
bug
bmcfee
commented
Feb 22, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
#827
What does this implement/fix? Explain your changes.
This PR adds an upper bound check on the
widthparameter ofsegment.recurrence_matrix.Left unchecked, a
width > data.shape[axis]results in an opaque error when we callsetdiagon the sparse neighbor graph. There's no reason to allow width to exceed the duration anyway (this will always produce an all-zeros matrix).Any other comments?
There's functionally no change here, but the exception that gets raised in this scenario is more user-friendly and should be easier to debug with. Assuming it passes CI, I see no need for CR.
This change is