Fix #13 use slack deltas for zero sized signatures. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also uses slack deltas for zero sized signatures.
I think this might have once had some meaning under our old autoconf setup.
Using 0 as your buffer size uses the recommended default which depends on the block size and task being performed. We should include this in our tests. This ensures that our tests that excersize various buffer sizes do.
|
This is a tiny fix for a bug. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses slack deltas for signatures of empty files. This means it doesn't bother doing rollsum calculations and hashtable lookups against an empty hashtable, instead just emitting literal commands. This makes it heaps more efficient. I added an empty input file for the changes.test to test this case.
I also removed a vestigial tests/dot file (leftover from autoconf?), and updated testcommon.py to include '0' in the tested buffer sizes so that it tests the recommended default buffer sizes, which depend on the block size and type of operation being performed.