Fix #176 rs_int_len() for large values. #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts this to what it was before, with some minor tidy ups. I believe that this is pretty much the only way to make it work when rs_long_t is of an unknown size. It's also pretty hard to write tests that will still pass on platforms where rs_long_t is less than 64bits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This reverts this to what it was before, with some minor tidy ups. I believe
that this is pretty much the only way to make it work when rs_long_t is of an
unknown size. It's also pretty hard to write tests that will still pass on
platforms where rs_long_t is less than 64bits.