directfb driver: yuv overlay creation will allways fail

[SDLBugzilla]

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• patch to correct issues (libsdl1.2.11_directfb_overlay.pat, text/plain, 2007-02-20 13:17:49 +0000, 474 bytes)

Reported in version: 1.2.11
Reported for operating system, platform: Linux, x86

Comments on the original bug report:

On 2007-02-20 13:15:08 +0000, wrote:

Due to changes in directfb 0.9.24, 0.9.25 YUV overlay creation will allways fail due to the fact that the code will not set a directfb coordination level. The following diff fixes the problem and will enable the use of hardware accelerated overlays using sdl over directfb.

--- libsdl1.2-1.2.11.orig/src/video/directfb/SDL_DirectFB_yuv.c
+++ libsdl1.2-1.2.11/src/video/directfb/SDL_DirectFB_yuv.c
@@ -118,6 +118,14 @@
break;
}

• ret = layer->SetCooperativeLevel( layer, DLSCL_ADMINISTRATIVE );
• if (ret)
• {

•   SetDirectFBError( "IDirectFBDisplayLayer::SetCooperativeLevel() failed",
  

ret );

•   layer->Release( layer );
  

•   return ret;
  

• }
  

• ret = layer->SetConfiguration (layer, &conf);
  if (ret)
  {

On 2007-02-20 13:17:49 +0000, wrote:

Created attachment 191
patch to correct issues

On 2007-02-20 16:07:13 +0000, Ryan C. Gordon wrote:

Fixed in svn revision # 2986 for the 1.2 branch, and # 2987 for the 1.3 branch.

Thanks!

--ryan.