Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade vendored libtiff to 4.6.0 for SDL3_image #397

Closed
sezero opened this issue Oct 29, 2023 · 4 comments
Closed

upgrade vendored libtiff to 4.6.0 for SDL3_image #397

sezero opened this issue Oct 29, 2023 · 4 comments

Comments

@sezero
Copy link
Contributor

sezero commented Oct 29, 2023

This will make us track latest libtiff with all bug fixes already in. I created a v4.6.0-SDL branch with two commits cherry-picked from master.

CC: @madebr: Can you prepare the rest, e.g. cmake'ry and such?

@madebr
Copy link
Contributor

madebr commented Oct 29, 2023

I pushed 2 little patches to make integration in SDL_image as frictionless as possible.

btw, libsdl-org/libtiff@0a44dce is not really needed for SDL_image's purpose.
It's only useful when you install a complete libtiff sdk, including headers and libraries. SDL_image does not install any tiff headers and/or win32 tiff import libraries.

@sezero
Copy link
Contributor Author

sezero commented Oct 29, 2023

OK, it's ready then?

@sezero
Copy link
Contributor Author

sezero commented Oct 29, 2023

P.S.: @slouken: Android.mk doesn't even mention tiff: We don't want to support tiff in android builds, or is it an oversight?

@madebr
Copy link
Contributor

madebr commented Oct 29, 2023

OK, it's ready then?

I tried building with my native toolchain + mingw, and it works. So you have a go from me :)

@sezero sezero closed this as completed in 4953d01 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants