Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grep for '<<include' #233

Closed
icculus opened this issue May 28, 2022 · 5 comments
Closed

Grep for '<<include' #233

icculus opened this issue May 28, 2022 · 5 comments
Assignees

Comments

@icculus
Copy link
Contributor

icculus commented May 28, 2022

Rather than stumble upon these forever, someone should just clean out all the '<<include' strings that did magic things in MoinMoin.

We've actually gotten a lot of them. Here's a search of what remains.

https://wiki.libsdl.org/wiki/search?q=%3C%3Cinclude

@madebr
Copy link
Contributor

madebr commented Jul 23, 2022

What is the correct fix for this? Copy and paste? Add a refernce?
Is https://wiki.libsdl.org/SGWikiBasics#includes outdated?

@icculus
Copy link
Contributor Author

icculus commented Jul 24, 2022

Any of the "SG" pages ("Style Guide") are almost certainly out of date at this point; they were written for the MoinMoin wiki right during the transition between SDL 1.2 and SDL 2.

I haven't looked through them, but they'd likely need updating for both MediaWiki syntax and just general truths that have changed in the last decade+.

@icculus
Copy link
Contributor Author

icculus commented Jul 24, 2022

Also, at some point ghwikipp started dropping the ?q=search_terms from that link, so that's a separate bug. :(

@icculus
Copy link
Contributor Author

icculus commented Jul 24, 2022

As to the question: the correct answer varies.

  • For extremely small things that never change: copy/paste.
  • For things that make sense to live on a separate page (or be part of an existing page), link to them and don't have it inline on every page.
  • For many other things: delete the "include" macro stuff. It's often not worth listing out the things we're listing out between pages like this.

But all of that's absolutely a decision that needs to be made per-page.

@icculus
Copy link
Contributor Author

icculus commented May 9, 2024

So all the MoinMoin << things are gone from the SDL3 wiki.

The Style Guide stuff is now deleted from SDL2's wiki (it already was for SDL3), but a handful of related things that do this still remain there...most of them will evaporate when we fix up the Category stuff in wikiheaders, I think.

@icculus icculus closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants