Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Warnings and use of actions-rs actions #188

Closed
rusty-snake opened this issue Nov 6, 2022 · 5 comments
Closed

CI Warnings and use of actions-rs actions #188

rusty-snake opened this issue Nov 6, 2022 · 5 comments
Labels
ci Improvements to CI

Comments

@rusty-snake
Copy link
Member

There are CI warnings because

All come from action-rs/toolchain and actions-rs/tarpaulin. For action-rs/toolchain they are tracked in actions-rs/toolchain#221 and actions-rs/toolchain#219. While actions-rs/tarpaulin does not have an issue for them yet.

Since both actions do not seem to see that much maintenance (last release ~1,5 years ago, Open PRs w/o any comments for over 1 year, Unmerged dependabot PRs with security updates, ...) I would put up for discussion whether we should not better get rid of them to avoid future problems.

@rusty-snake rusty-snake added the ci Improvements to CI label Nov 6, 2022
@ManaSugi
Copy link
Member

ManaSugi commented Nov 8, 2022

@rusty-snake Thank you for the information!

As you mentioned, actions-rs/toolchain does not seem to be maintained for a long time, so we may have to start considering
an alternative action, just using rustup or stuff like that in order to avoid future problems.
On the other hand, the actions-rs/tarpaulin seems to be maintained actively, so I hope the mainteiner will handle this problem.
Could you create the issue for actions-rs/tarpaulin in order to tell it to the maintainers when you have time?

@rusty-snake
Copy link
Member Author

cargo-tarpaulin itself is maintained. However we use it through the actions-rs/tarpaulin action.
It has three commits in the last two years, but if you wait two days (timezone ...) it will have zero commits in the last two years 😀 .

actions-rs has one public member, who has a lot activity in 2019/2020 and very less in 2021/2022.

For toolchain we could use https://github.com/marketplace/actions/rustup-toolchain-install.

For tarpaulin we need to write our own bash/python script, call it directly or find an other action. grcov does not seem to have an action either.

@ManaSugi
Copy link
Member

ManaSugi commented Nov 9, 2022

cargo-tarpaulin itself is maintained. However we use it through the actions-rs/tarpaulin action.

Oh, you're right.

For toolchain we could use https://github.com/marketplace/actions/rustup-toolchain-install.

That's good an alterative action! We could use it instead of actions-rs/toolchain.
Regarding actions-rs/tarpaulin, I think we might as well write our own bash script in build-test.yaml directly. That won't be so many lines. In addition, It would be nice to switch to source-based coverage of cargo tarpaulin in the future in order to get more accurate coverage when it is available.
Ref. https://github.com/xd009642/tarpaulin/issues?q=is%3Aissue+is%3Aopen+%23549+

@rusty-snake
Copy link
Member Author

@ManaSugi since you have more knowledge with tarpaulin, I would leave it to you to replace the tarpaulin action.

rusty-snake added a commit to rusty-snake/libseccomp-rs that referenced this issue May 1, 2023
cargo-tarpaulin changed the nameing of release artifacts over three
month ago. Unmaintained actions-rs/tarpaulin did not picked it up until
now breaking CI.

Ref: actions-rs/tarpaulin#15

We still want to replace the action with an other action, an direct call
to cargo-taroaulin or use grcov, see libseccomp-rs#188.

Signed-off-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
ManaSugi pushed a commit that referenced this issue May 8, 2023
cargo-tarpaulin changed the nameing of release artifacts over three
month ago. Unmaintained actions-rs/tarpaulin did not picked it up until
now breaking CI.

Ref: actions-rs/tarpaulin#15

We still want to replace the action with an other action, an direct call
to cargo-taroaulin or use grcov, see #188.

Signed-off-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
@ManaSugi
Copy link
Member

This issue has been solved by the following commits.
5dcd06c
1748422

So, I can close this. Thanks! @rusty-snake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Improvements to CI
Projects
None yet
Development

No branches or pull requests

2 participants