Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for AhoCorasick #169

Merged
merged 13 commits into from
May 29, 2024
Merged

Add support for AhoCorasick #169

merged 13 commits into from
May 29, 2024

Conversation

Joseph-Edwards
Copy link
Collaborator

This PR adds the bindings, documentation and tests for the AhoCorasick class

@Joseph-Edwards Joseph-Edwards changed the base branch from main to v1 May 28, 2024 17:46
@Joseph-Edwards
Copy link
Collaborator Author

This will fail until libsemigroups/libsemigroups#545 is merged

@Joseph-Edwards
Copy link
Collaborator Author

I've tried to use iwyu, but I'm not 100% confident on when I should be using #include <path> vs #include "path". My understanding is use <path> unless the file is somehow local (which is only main.hpp in this case).

Is this the right way to think about it @james-d-mitchell ?

@james-d-mitchell
Copy link
Member

That's right @Joseph-Edwards enough for our purposes here!

@james-d-mitchell james-d-mitchell merged commit f0950d0 into libsemigroups:v1 May 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Joseph-Edwards @james-d-mitchell