Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2020-19668: Unverified indexes into array lead to out of bound access in the gif_out_code function in fromgif.c in libsixel 1.8.6. #7

Closed
ctrlcctrlv opened this issue Jun 9, 2021 · 0 comments · Fixed by #8

Comments

@ctrlcctrlv
Copy link
Collaborator

This is a tracking issue, our version of saitoha#136. I already have a solution.

ctrlcctrlv added a commit that referenced this issue Jun 9, 2021
The type `unsigned short`, which is the type of the LZW code, is much
larger than the max of an LZW code, causing a wild pointer.

That causes an array overflow. Long term, this library should jettison
this unnecessary GIF code, and use a better maintained library for it.
In the meantime, however, the issue is simple enough to solve, so I've
done so.

Resolves CVE-2020-19668.
Closes saitoha#136.
Closes #7.
ctrlcctrlv added a commit that referenced this issue Jun 9, 2021
The type `unsigned short`, which is the type of the LZW code, is much
larger than the max of an LZW code, causing a wild pointer.

That causes an array overflow. Long term, this library should jettison
this unnecessary GIF code, and use a better maintained library for it.
In the meantime, however, the issue is simple enough to solve, so I've
done so.

Resolves CVE-2020-19668.
Closes saitoha#136.
Closes #7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant