cairo error->exit(1) and replace Kaiser window with Hanning #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, an error in cairo initialization, for example because the output file would be >32767 pixels wide, caused sndfile-spectrogram to exit with 0 exit status, which makes detecting sndfile-spectrogram failure difficult in shell scripts. This change makes it exit(1) instead.
sndfile-spectrogram's output was visibly noisy for pure tones and less visibly noisy for other signals. This change improves the output quality by replacing the Kaiser window function that it was using by a Hanning window, which gives the best output of the twelve functions tried (Kaiser, Nuttall, Rectangular, Bartlett, Hamming, Hanning, Blackman, Blackman-Harris, Welch and first- second- and third-order Gaussian).
|
Can we separate out the Cairo error handling from the windowing changes? And for the windowing, how about providing an option to choose between windows so that I (and others) can compare and contrast more easily? |
|
OK, I've made a new pull request for the error-handling change. |
|
Got it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most significant of these is to fix issue #15 by changing window function.
An alternative would be an option to select windowing function, but Hanning seems to work best.