Make a Cairo failure cause sndfile-spectrogram to exit(1), not exit(0) #27

martinwguy · 2015-12-06T13:42:32Z

When Cairo init failed, typically because the output image was >32768 wide,
sndfile-sprectogram would exit(0). This makes it exit(1) so that wrapping
shell scripts can more reliably detect sndfile-spectrogram failure.

When Cairo init failed, typically because the output image was >32768 wide, sndfile-sprectogram would exit(0). This makes it exit(1) so that wrapping shell scripts can more reliably detect sndfile-spectrogram failure.

The Kaiser window is noisy on certain input data. e.g.: sndfile-generate-chirp -amp 1.0 -linear -from 22000 -to 26000 \ 96000 10 chirp96.wav sndfile-spectrogram chirp96.wav 800 600 chirp96.png Other window functions (Nuttall, Hanning) do not have this problem. This patch add a --nuttall option to select the Nuttall window function, whose code is already included in the source, as an alternative to the default one, the Kaiser window. There is a --kaiser option for symmetry. An alternative would be --window=nuttall so we can beat Audacity's ten (!) different window functions but --nuttall is easier to parse (and to type!)

erikd · 2015-12-06T19:37:37Z

Travis is busted. This has been applied.

martinwguy added 2 commits December 6, 2015 14:38

erikd closed this Dec 6, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make a Cairo failure cause sndfile-spectrogram to exit(1), not exit(0) #27

Make a Cairo failure cause sndfile-spectrogram to exit(1), not exit(0) #27

martinwguy commented Dec 6, 2015

erikd commented Dec 6, 2015

Make a Cairo failure cause sndfile-spectrogram to exit(1), not exit(0) #27

Make a Cairo failure cause sndfile-spectrogram to exit(1), not exit(0) #27

Conversation

martinwguy commented Dec 6, 2015

erikd commented Dec 6, 2015