fix use-of-uninitialized-value #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return error if malloc(0)
|
Looks good, thanks! |
willco007
added a commit
that referenced
this pull request
May 28, 2020
file: transport.c notes: moving total_num zero length check from #476 up to the prior bounds check which already includes a total_num check. Makes it slightly more readable. credit: Will Cosgrove
willco007
added a commit
that referenced
this pull request
May 28, 2020
willco007
pushed a commit
to willco007/libssh2
that referenced
this pull request
Sep 2, 2020
file:transport.c notes: return error if malloc(0) credit: lutianxiong
willco007
added a commit
to willco007/libssh2
that referenced
this pull request
Sep 2, 2020
file: transport.c notes: moving total_num zero length check from libssh2#476 up to the prior bounds check which already includes a total_num check. Makes it slightly more readable. credit: Will Cosgrove
|
CVE-2020-22218 was assigned to this, and NVD scored it as "high" severity. I had not involvement in the assignment. I'm commenting here for reference. |
halstead
pushed a commit
to openembedded/meta-openembedded
that referenced
this pull request
Oct 24, 2023
Bug: libssh2/libssh2#476 Upstream-Status: Backport [libssh2/libssh2@642eec4 & libssh2/libssh2@0b44e55] Signed-off-by: Vijay Anusuri <vanusuri@mvista.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
jpuhlman
pushed a commit
to MontaVista-OpenSourceTechnology/meta-openembedded
that referenced
this pull request
Nov 3, 2023
Source: meta-openembedded MR: 128824, 129002 Type: Security Fix Disposition: Merged from meta-openembedded ChangeID: 300be97 Description: Bug: libssh2/libssh2#476 Upstream-Status: Backport [libssh2/libssh2@642eec4 & libssh2/libssh2@0b44e55] Signed-off-by: Vijay Anusuri <vanusuri@mvista.com> Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
malloc(0) may not always return NULL, return error if 'total_num = 0' in _libssh2_transport_read in case of 'payload' will be used later