Misc fixes #152
Merged
Misc fixes #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cathay4t
commented
May 15, 2016
•
cathay4t
commented
- Fix a bug introduced by PR Fix RHEL/Fedora mock build test failure. #150.
- Add new configure option to skip memory leak check test.
- Fix lsm_local_disk_vpd83_search() for RHEL/Fedora mock build.
|
@tasleson Sorry, we might need 1.3.2 release as I introduced a regression bug into 1.3.1. |
|
Found more issue on lsm_local_disk.c, fixing. |
|
New patch included for lsm_local_disk_vpd83_search() in RHEL/Fedora mock build. |
|
|
||
| assert(path != NULL); | ||
|
|
||
| fd = open(path, O_RDONLY); | ||
| if (fd == -1) { |
There was a problem hiding this comment.
I would suggest changing this to:
if ( fd == -1 && errno == ENOENT)
so that we are examining errno only when open returns an error, see:
http://www.gnu.org/software/libc/manual/html_node/Checking-for-Errors.html
for more information.
Problem:
The lsm_local_disk_list() will not include any disks when running as
non-root user.
Root cause:
The _file_exists() try to open disk path as read only which normally
only failed on non-root user.
Fix:
Only indicate file not exist when got ENOENT error.
Signed-off-by: Gris Ge <fge@redhat.com>
* New option '--without-mem-leak-test' to './configure' which could disable memory leak check. Signed-off-by: Gris Ge <fge@redhat.com>
Problem:
RHEL/Fedora mock build will fail as lsm_local_disk_vpd83_search()
failed to find provided disks.
Root cause:
'/dev' is not mounted in RHEL/Fedora mock build. The disk path list
generated by _sysfs_get_all_sd_names() do not actually exist in /dev/
folder.
Fix:
Use lsm_local_disk_list() to enumerate local disks and remove
unneeded function _sysfs_get_all_sd_names().
Signed-off-by: Gris Ge <fge@redhat.com>
|
Thank you for the note. Fixed. |
|
@cathay4t Thanks Gris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.