Misc fixes #343
Merged
Misc fixes #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was resulting in unreachable code for 'HTTP error' in desc. Signed-off-by: Tony Asleson <tasleson@redhat.com>
Signed-off-by: Tony Asleson <tasleson@redhat.com>
From looking at the code, I believe the intention was to retun 'None' if we get a parse error for a line in the export data. Otherwise, we have unreachable code as the 'return None' would never execute. Signed-off-by: Tony Asleson <tasleson@redhat.com>
tasleson
commented
Oct 1, 2018
| @@ -175,7 +175,7 @@ def _parse_export(parts=None): | |||
| anonuid, anongid, optionstring) | |||
| return result | |||
| except: | |||
| raise | |||
| pass | |||
There was a problem hiding this comment.
@jumitche Does this look correct to you?
There was a problem hiding this comment.
Yes, that looks okay.
Closed
alice-mitchell
approved these changes
Oct 8, 2018
| @@ -175,7 +175,7 @@ def _parse_export(parts=None): | |||
| anonuid, anongid, optionstring) | |||
| return result | |||
| except: | |||
| raise | |||
| pass | |||
There was a problem hiding this comment.
Yes, that looks okay.
|
@jumitche Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct some typos and unreachable code.