Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ordinals and inscriptions functionality #142

Merged
merged 27 commits into from
Mar 29, 2023
Merged

Conversation

jadwahab
Copy link
Member

No description provided.

@mergify mergify bot added the feature label Mar 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Patch coverage: 43.40% and project coverage change: -2.91 ⚠️

Comparison is base (f7971e5) 83.70% compared to head (7937c55) 80.80%.

❗ Current head 7937c55 differs from pull request most recent head 769e763. Consider uploading reports for the commit 769e763 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   83.70%   80.80%   -2.91%     
==========================================
  Files          34       37       +3     
  Lines        3701     3985     +284     
==========================================
+ Hits         3098     3220     +122     
- Misses        434      546     +112     
- Partials      169      219      +50     
Impacted Files Coverage Δ
output.go 86.95% <ø> (ø)
utxo.go 75.00% <ø> (ø)
inscriptions.go 28.00% <28.00%> (ø)
tx.go 76.07% <28.57%> (-1.22%) ⬇️
unlocker/simple.go 59.09% <33.33%> (-5.91%) ⬇️
bscript/script.go 59.59% <37.70%> (-5.66%) ⬇️
ord/bidding.go 50.00% <50.00%> (ø)
ord/listing.go 52.23% <52.23%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

utxo.go Outdated Show resolved Hide resolved
@jadwahab
Copy link
Member Author

Note sure if we should split out the ordinals files into a separate directory/module or keep them in the main bt module package. We could even potentially make the receiver functions on bt.Tx but I think it's better to keep it a separate function that takes the tx in the Args struct.

Leaning towards separating out, but if anyone has any better ideas please let me know.

@jadwahab jadwahab changed the title add ordinals and inscriptions functionality Add ordinals and inscriptions functionality Mar 29, 2023
@jadwahab jadwahab merged commit ce5d9c0 into master Mar 29, 2023
@jadwahab jadwahab deleted the feat/inscriptions branch March 29, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants