Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: NewP2PKHFromBip32ExtKey #57

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Conversation

tigh-latte
Copy link
Contributor

Utility func for creating a randomly derived output script from a *bip32.ExtendedKey.

@tigh-latte tigh-latte requested review from jadwahab and theflyingcodr and removed request for jadwahab September 27, 2021 14:41
@mergify mergify bot added the feature label Sep 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2021

Codecov Report

Merging #57 (a2aae74) into master (7440322) will decrease coverage by 0.02%.
The diff coverage is 80.95%.

❗ Current head a2aae74 differs from pull request most recent head 5d47176. Consider uploading reports for the commit 5d47176 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   84.76%   84.73%   -0.03%     
==========================================
  Files          28       28              
  Lines        3012     3033      +21     
==========================================
+ Hits         2553     2570      +17     
- Misses        325      327       +2     
- Partials      134      136       +2     
Impacted Files Coverage Δ
bscript/script.go 59.79% <66.66%> (+0.45%) ⬆️
txoutput.go 82.50% <100.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7440322...5d47176. Read the comment docs.

Copy link
Contributor

@theflyingcodr theflyingcodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small grammar thing in a comment, apart from that looks good

bscript/script.go Outdated Show resolved Hide resolved
Copy link
Contributor

@theflyingcodr theflyingcodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit c6f805c into master Oct 12, 2021
@mergify mergify bot deleted the feat/new-p2pkf-bip32-extkey branch October 12, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants