Enhancement: ReadFrom for bt.Txs #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2021 09:39
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 83.77% 83.69% -0.08%
==========================================
Files 35 35
Lines 3624 3656 +32
==========================================
+ Hits 3036 3060 +24
- Misses 424 428 +4
- Partials 164 168 +4
Continue to review full report at Codecov.
|
jadwahab
reviewed
Dec 10, 2021
| // Create buffered reader for this file. | ||
| r := bufio.NewReader(f) | ||
|
|
||
| // Read file header. This is step is specific to file reading and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
ReadFromto thebt.Txstype, along with an example on how to use, to further abstract the chunking of a binary block.This way users don't need to worry about the varint or tracking their progression through a byte stream.