Fix: Change network value from mainnet to regtest #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theflyingcodr
requested changes
Oct 6, 2021
service/paymentrequest.go
Outdated
| @@ -51,7 +53,7 @@ func (p *paymentRequest) CreatePaymentRequest(ctx context.Context, args p4.Payme | |||
| // here we store paymentRef in extended data to allow some validation in payment flow | |||
| merchant.ExtendedData["paymentReference"] = args.PaymentID | |||
| return &p4.PaymentRequest{ | |||
| Network: "mainnet", | |||
| Network: string(p.deployCfg.Network), | |||
There was a problem hiding this comment.
This should probably come from payd actually rather than being set on P4, this has been something on my internal backlog to fix but hadn't got round to it yet.
There was a problem hiding this comment.
So should payd be dumb to the network it's running against as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in testing the payment body says
"network": "mainnet"on regtest.