Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding libtommath to the Libs #610

Closed
Apteryks opened this issue Jan 15, 2023 · 2 comments · Fixed by #611
Closed

adding libtommath to the Libs #610

Apteryks opened this issue Jan 15, 2023 · 2 comments · Fixed by #611

Comments

@Apteryks
Copy link

Hello,

We carry a patch in GNU Guix which modifies the pkg-config.pc.in file so that libtommath is also added to Libs (Libs: -L${libdir} -ltomcrypt -ltommath).

Would it make sense to be applied here (upstream) ?

Thanks!

@sjaeckel
Copy link
Member

The issue here is that libtommath is no hard dependency but a compilation choice.

One can choose out of the following three MPI providers libtommath, tomsfastmath and gnump (or any combination of the three) when compiling libtomcrypt.

The bad part of the current solution is that always all configured MPI providers have to be linked ... it's only a runtime decision of the user which MPI provider to use in the end ...

Would you be fine with the proposed solution?

@Apteryks
Copy link
Author

Hi! Thanks for working on a solution; it seems sensible to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants