Make the build logic more robust for BSD systems

[ararslan]

This properly sets MAKE on BSDs to gmake rather than make, which refers to the incompatible BSD Make. Further, it betters detection of Clang as the default compiler, which is the case on FreeBSD 11.0+ and OpenBSD 6.0+, and it fixes the unrecognized call to arch on FreeBSD.

[sjaeckel]

Thanks a lot!

We made sure that makefile.unix is Posix/BSD make compatible, but that's a nice addition that the original makefile and makefile.shared can now also be used on these platforms.

Btw. did you try both, makefile and makefile.shared?

Should we also port these changes to libtomcrypt?

[ararslan]

(Sorry, had to fix some syntax. I was working on this between two computers yesterday and messed something up.)

We made sure that makefile.unix is Posix/BSD make compatible

I don't see a makefile.unix anywhere. Am I missing something? Even the FreeBSD port for LibTomMath uses GNU Make (and has to work around some of the issues I've addressed here).

Btw. did you try both, makefile and makefile.shared?

Yes, both gmake and gmake -f makefile.shared work as expected on FreeBSD with these changes.

Should we also port these changes to libtomcrypt?

Hm, I've not looked at libtomcrypt before, but it's quite likely that the same set of changes would be beneficial. I can submit a PR there.

[sjaeckel]

(Sorry, had to fix some syntax. I was working on this between two computers yesterday and messed something up.)

No worries

I don't see a makefile.unix anywhere. Am I missing something? Even the FreeBSD port for LibTomMath uses GNU Make (and has to work around some of the issues I've addressed here).

oops, right, that port of makefile.icc to makefile.unix was only done for ltc then... sorry :)

Yes, both gmake and gmake -f makefile.shared work as expected on FreeBSD with these changes.

👍

Hm, I've not looked at libtomcrypt before, but it's quite likely that the same set of changes would be beneficial. I can submit a PR there.

Cool! That'd be great - thx!

[ararslan]

PR to libtomcrypt: libtom/libtomcrypt#382

[ararslan]

Figured out the escaping issues and applied here.

[sjaeckel]

Can you please bring this in sync with the PR in ltc?

[ararslan]

Done.

[sjaeckel]

Sorry, but can you please rebase :) I'll merge afterwards!

[ararslan]

Done!