allow tomsfastmath to be built without stdlib #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only use of `malloc`/`free` in tomfastmath is in src/numtheory/fp_prime_random_ex.c, and the size required can be calculated from the function arguments, so we can just use a variable-length automatic array instead. Variable-length automatic arrays are a C99 feature, and TFM already doesn’t compile as C90, so we might as well take advantage of it.
fp_ident is the only place tomsfast math uses string manipulation functions when built as a library. This commit replaces them with safe, trivial functions for concatonating static strings and numbers together.
This commit enables tomsfastmath to be built with `--no-standard-libraries` provided `TFM_NO_STDLIB` is defined, which happens automatically if a web assembly build target is detected. The only functionality this disables is the `fp_rand` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables tomsfastmath to be built with
--no-standard-librariesprovidedTFM_NO_STDLIBis defined, which happens automatically if a web assembly build target is detected.The only functionality this disables is the
fp_randfunction.This pull request is also contains the required changes in #32 and #33.