Improve ts_uinput_start.sh script #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script is compatible with sh. This means, the shebang line can be safely changed to point to sh instead of bash. This allows to use this script on more platforms, especially when only sh is available. Signed-off-by: Daniel Semkowicz <dse@thaumatec.com>
There was unnecessary call to "ls". ts_uinput output can be grepped directly for 'event' string, without creating additional variable. Simplify "! -z" to "-n" as suggested by shellcheck. Signed-off-by: Daniel Semkowicz <dse@thaumatec.com>
|
lgtm. thanks for the patches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running shellcheck on this script reported following problems: SC2010, SC2086, SC2236.
This MR includes following changes to
ts_uinput_start.shscript:sh