Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idempotency guard to uiInit() on all platforms #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cody271
Copy link
Contributor

@cody271 cody271 commented Jun 24, 2022

No description provided.

@szanni
Copy link
Contributor

szanni commented Jun 24, 2022

Looks good in principle to me, however it actually breaks the uiInit(); uiUninit(); uiInit(); sequence on all platforms, not only darwin as highlighted in #118.

I believe setting the variable to false in uiUninit() would do the trick. In that case renaming the variable to something like uiprivInitialized would be more appropriate as well.

@e1732a364fed
Copy link

please check this issue before merge

#160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants