ci: Add libtype shared to meson-windows #149
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. @cody271 @szanni and everyone.
I have a question and a pull request.
I would like to create a Ruby package containing a pre-release version of libui-ng.
But for now, I am attaching a Rake (Rake is the Ruby equivalent of Make) script that can download a build of libui-ng from the nightly.link you gave us so that people who want to use libui-ng can easily try it out.
However, on Windows, there is no shared library because shared is not enabled in the build.yml. Browsing through the blame, I noticed that @cody271 has intentionally disabled shared in the past. (9210b9f)
To see if it works, I ran ci with
shared
enabled in the forked repository of libui-ng. Then libui.dll was generated.https://github.com/kojix2/libui-ng/actions/runs/3258763203
The attached test file worked and I was able to call libui.dll from Ruby's LibUI. Of course I didn't look at all of them, and there may be something wrong with them, but at first glance they appear to be working.
So my question is: What is the reason that this option is disabled?
Would you consider enabling this option if possible?