Fix meson subproject inclusion by making options project specific. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `add_project_*_arguments` instead of `add_global_*_arguments`.
Use the new meson 63 `diff_files` mechanism to patch the cmocka meson.build, building it as a fat binary and specifying the minimum OSX SDK version.
|
The second commit adds a diff file to patch the cmocka Failing of the CI seems related to brew, not the patch from what I can tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
add_project_*_argumentsinstead ofadd_global_*_arguments.Fixes #152This now breaks the building of cmocka. Guess this needs some further thought after all... possibly just disable the building of tests when being built as a submodule?