Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some modifications about Windows platform #211

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

some modifications about Windows platform #211

wants to merge 2 commits into from

Conversation

Fsu0413
Copy link

@Fsu0413 Fsu0413 commented Jun 23, 2023

  1. UB when using LTO - same name in structure in different file breaks it
  2. libui-ng provided ABI bug workaround does not compile using llvm-mingw. Since the ABI bug workaround is already provided by newer MinGW-w64 under macro let's just judge if the macro exists.

@cody271
Copy link
Contributor

cody271 commented Jul 1, 2023

Hi @Fsu0413, looks good! We don't actually have Clang on Windows in the CI build.. I'll have to do some more thorough testing locally before merge.

@cody271 cody271 mentioned this pull request Jul 1, 2023
Open
@Fsu0413
Copy link
Author

Fsu0413 commented Jul 1, 2023

It is fine not maintain Clang support here. I just find this useful when I am playing with this project.
Also there is also newer version of mingw-builds on GitHub, which is using newer version of MinGW-w64 and GCC. The newer version also comes with the ABI bug workaround.

@msink
Copy link
Contributor

msink commented Jul 1, 2023

#83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fsu0413 @cody271 @msink