qa: Add uiProgressBar tests and fix darwin. #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify that the indeterminate progress bar animation is properly started/stopped depending on the value set.
uiProgressBarSetValue(-1) will not display a correct indeterminate progress bar animation if a value other than -1 has previously been set. Fixes: qa > uiProgressBar > Progress Bar Indeterminate Start/Stop Animation
Kill the progress bar animation thread to visually display the value change when setting a value [0, 100] when the progress bar is in an indeterminate state. This removes the ~1 second delay that it would otherwise take on macOS 11.7 and possibly other versions.
|
I can't confirm the issue on my mac. Here are the results. 1. Progress Bar Valuesqa-progressbar-win.mp4qa-progressbar-linux.mp4qa-progressbar-mac.mp42. Progress Bar Indeterminate Start/Stop Animationqa-progressbar-win-2.mp4qa-progressbar-linux-2.mp4qa-progressbar-mac-2.mp4 |
|
This is a nit but I noticed $ git -c 'core.whitespace=trailing-space,space-before-tab,indent-with-non-tab,tabwidth=2' --no-pager diff --check origin/master
test/qa/entry.c:156: new blank line at EOF.
test/qa/progressbar.c:91: new blank line at EOF.
And the message for |
|
I also noticed the moving progressbar stops its animation when resizing the parent window on Ubuntu 20.04. qa-progressbar-linux-resize.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two visual tests for uiProgressBar.
The second one fails on my system: macOS 11.7 (Big Sur) . Setting
-1after previously having set some other value will not return to the expected moving bar animation as before but flash the last value in a weird way.The third patch in this series fixes this by calling
[p->pi displayIfNeeded];.Another thing that seems to work is calling
[p->pi setUsesThreadedAnimation:NO];and[p->pi setUsesThreadedAnimation:YES];but I found this to be cleaner.Another possible issue that
qa > uiProgressBar > 2.highlights is the delay when setting a value on darwin whilst the progress bar is animating.I was able to get an instant set by encapsulating thesetIndeterminatecall. Happy to include that in this patch set.Edit: I included the patch to stop the animation instantly (by killing the thread) and set the new value without the (~1 second) delay I was experiencing on my system.
I also added an early return when setting
-1when we are already animating to match unix and windows. Good old defensive programming.