Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array indexing bug in dwarf_search_unwind_table #579

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix array indexing bug in dwarf_search_unwind_table #579

merged 1 commit into from
Jul 10, 2023

Conversation

sfc-gh-bhannel
Copy link
Contributor

@sfc-gh-bhannel sfc-gh-bhannel commented Jul 10, 2023 •
edited

The variable table is of type struct table_entry *, and table_len is in bytes, so the index one past the end is properly table_len / sizeof (struct table_entry). The previous implementation would read unallocated memory. This issue was detected with ASAN, and ASAN verified the fix no longer reads unallocated memory.

@bregma bregma merged commit 8cd667c into libunwind:master Jul 10, 2023
11 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfc-gh-bhannel @bregma