Fallback to direct access instead of through /proc/[pid]/root/ #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some namespace setups the binary might not even be present in the mnt_ns. This is the case if it's launched from an fd in a specially prepared empty mnt_ns via a execveat (sandboxing usecase). Therefore it makes sense to fallback to the original path.
|
It seems to me this will always revert to the original path since |
copybara-service bot
pushed a commit
to google/sandboxed-api
that referenced
this pull request
Aug 24, 2023
It was fixed internally and libunwind/libunwind#602 should make it better for OSS. PiperOrigin-RevId: 559772982 Change-Id: Ifcbf824d37cb4988dc56db20a8bbaaaf52a2cb81
|
It's |
|
Ah, OK, I was misreading the preceding code. This is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some namespace setups the binary might not even be present in the mnt_ns. This is the case if it's launched from an fd in a specially prepared empty mnt_ns via a execveat (sandboxing usecase).
Therefore it makes sense to fallback to the original path.