Don't check if the memory is in core #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libunwind uses mincore() to validate that memory is mapped and available to the process. For this purpose, checking the return value of mincore() is sufficient. The result array tells us if the kernel has swapped out the page or not. We don't care about this, and the check leads to failure in those cases where the kernel has swapped out the page.
djwatson
pushed a commit
that referenced
this pull request
Mar 31, 2020
libunwind uses mincore() to validate that memory is mapped and available to the process. For this purpose, checking the return value of mincore() is sufficient. The result array tells us if the kernel has swapped out the page or not. We don't care about this, and the check leads to failure in those cases where the kernel has swapped out the page. Co-authored-by: ShutterQuick <shutter@canternet.org>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libunwind uses mincore() to validate that memory is mapped and available to the process.
For this purpose, checking the return value of mincore() is sufficient.
The result array tells us if the kernel has swapped out the page or not.
We don't care about this, and the check leads to failure in those
cases where the kernel has swapped out the page.