Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use of libabigail for ABI checks #684

Merged
merged 1 commit into from May 14, 2024
Merged

Conversation

bregma
Copy link
Member

@bregma bregma commented Dec 15, 2023

Added make -C src check-abi target to leverage libabigail 2.0 tools to check for ABI changes.

Add ABI baseline files for aarch64, i686, riscv, s390x, and x86_64 Linux targets and aarch64 and x86_64 QNX SDP 7.1 targets.

Used the check-abi target in the CI-unix github workflow.

@bregma bregma force-pushed the add-abi-checks branch 2 times, most recently from e7ff272 to 3cfcda4 Compare December 15, 2023 19:38
src/Makefile.am Outdated Show resolved Hide resolved
@bregma bregma force-pushed the add-abi-checks branch 4 times, most recently from 41ad9da to 6e9f910 Compare December 19, 2023 17:50
@bregma
Copy link
Member Author

bregma commented Dec 19, 2023

Found a better, more elegant way to generate and process the ABI files by using make rules instead of shell scripting.

@bertwesarg
Copy link
Contributor

Found a better, more elegant way to generate and process the ABI files by using make rules instead of shell scripting.

nice. just in case you want a custom prefix instead of the generic GEN. put something like this into your Makefile.am:

UNW_V_ABIDW = $(unw__v_ABIDW_@AM_V@)
unw__v_ABIDW_ = $(unw__v_ABIDW_@AM_DEFAULT_V@)
unw__v_ABIDW_0 = @echo "  ABIDW    $@";
unw__v_ABIDW_1 =
UNW_V_ABIDIFF = $(unw__v_ABIDIFF_@AM_V@)
unw__v_ABIDIFF_ = $(unw__v_ABIDIFF_@AM_DEFAULT_V@)
unw__v_ABIDIFF_0 = @echo "  ABIDIFF  $@";
unw__v_ABIDIFF_1 =

and use $(UNW_V_ABIDW) and $(UNW_V_ABIDIFF)

src/Makefile.am Show resolved Hide resolved
src/Makefile.am Show resolved Hide resolved
src/Makefile.am Show resolved Hide resolved
@bregma
Copy link
Member Author

bregma commented Feb 15, 2024

The archived ABI files need to be generated against a build configured with --enable-debug because that configuration flag changes the ABI and it's used in CI. Maybe there should be two sets of archived ABI files, one for with --enable-debug and one for without?

@bregma bregma force-pushed the add-abi-checks branch 6 times, most recently from 376cebf to 566afd2 Compare May 13, 2024 15:58
Added `make -C src check-abi` target to leverage libabigail 2.0 tools to
check for ABI changes.

Add ABI baseline files for aarch64, i686, riscv, s390x, and x86_64 Linux
targets and aarch64 and x86_64 QNX SDP 7.1 targets.

Used the check-abi target in the CI-unix github workflow.
@bertwesarg
Copy link
Contributor

LGTM

@bregma bregma merged commit 8b9a387 into libunwind:master May 14, 2024
15 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants