Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: add missing include for mingw32 #348

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

selsta
Copy link
Contributor

@selsta selsta commented Nov 10, 2021

Seems to be introduced in #309

2021-11-10T00:31:43.7352733Z hid.c:164:83: error: unknown type name ‘DEVPROPKEY’
2021-11-10T00:31:43.7355003Z   typedef CONFIGRET(__stdcall* CM_Get_DevNode_PropertyW_)(DEVINST dnDevInst, CONST DEVPROPKEY* PropertyKey, DEVPROPTYPE* PropertyType, PBYTE PropertyBuffer, PULONG PropertyBufferSize, ULONG ulFlags);

@Youw
Copy link
Member

Youw commented Nov 10, 2021

Could you confirm that the header name as provided by MinGW is exactlty devpropdef.h? And not Devpropdef.h (First letter caseness, it is upper-case in Windows SDK)?
Otherwise , if it doesn't match, it will fail during cross-compilation from Linux.

@selsta
Copy link
Contributor Author

selsta commented Nov 10, 2021

lrwxrwxrwx  1 root root    42 Nov 15  2019 devpropdef.h -> ../../share/mingw-w64/include/devpropdef.h

Seems to be devpropdef.h, though I have seen the capitalized spelling here: https://docs.microsoft.com/en-us/previous-versions/ff543546(v=vs.85)

Otherwise , if it doesn't match, it will fail during cross-compilation from Linux.

Cross compiling from Linux is how I triggered this issue in the first place (monero-project/monero#8055), with the patch applied it compiled fine.

Copy link
Member

@Youw Youw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be devpropdef.h, though I have seen the capitalized spelling here

This is exactly why I've asked to double-check.

Thanks.

@Youw Youw merged commit eb26015 into libusb:master Nov 10, 2021
@selsta selsta deleted the windows-include branch November 10, 2021 23:31
@mcuee mcuee added the Windows Related to Windows backend label Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows Related to Windows backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants