libusb: stop read_thread from looping indefinitely (#456)
#457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When `libusb_submit_transfer` in `read_thread` fails, `read_callback` never gets called and never sets `transfer_loop_finished` to true, causing `read_thread` to loop indefinitely. - Fix this by skipping the handle_events for the transfer - Fixes #456
|
I see that you have approved this, but the one of the CI checks seems to be still waiting for completion. Is there anything I can do to fix this? |
|
No worries, that is not a blocker. |
|
Ah, ok. So when does this eventually get merged in? |
jclulow
pushed a commit
to oxidecomputer/hidapi
that referenced
this pull request
Mar 28, 2024
- When `libusb_submit_transfer` in `read_thread` fails, `read_callback` never gets called and never sets `transfer_loop_finished` to true, causing `read_thread` to loop indefinitely; - Do not attempt to run a read loop if the initial `libusb_submit_transfer` fails fixes the issue; Fixes: libusb#456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
libusb_submit_transferinread_threadfails,read_callbacknever gets called and never setstransfer_loop_finishedto true, causingread_threadto loop indefinitely.Fix this by skipping the handle_events for the transfer
Fixes hidapi-libusb: if
libusb_submit_transferfails in read_thread,hid_closehangs #456