Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression 1.0.24] Device is not enumerated on Linux #831

Closed
Lekensteyn opened this issue Dec 26, 2020 · 2 comments
Closed

[Regression 1.0.24] Device is not enumerated on Linux #831

Lekensteyn opened this issue Dec 26, 2020 · 2 comments
Labels
Milestone

Comments

@Lekensteyn
Copy link

Lekensteyn commented Dec 26, 2020

After upgrading from 1.0.23-3 to 1.0.24-1 on Arch Linux, lsusb fails to show an iPhone 12 Pro. As usbmuxd depends on libusb for enumeration, that also failed to find any devices. git bisect pointed to:

e2be556 is the first bad commit

commit e2be556bd262cd260bebe3fc724509692537eba3
Author: Chris Dickens <christopher.a.dickens@gmail.com>
Date:   Wed Apr 29 12:39:35 2020 -0700

    linux_usbfs: Parse config descriptors during device initialization
    
    Do the work ahead of time and cache the results so that fetching config
    descriptors becomes a trivial operation.
    
    Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>

 libusb/os/linux_usbfs.c | 263 ++++++++++++++++++++++++++----------------------
 libusb/version_nano.h   |   2 +-
 2 files changed, 145 insertions(+), 120 deletions(-)

Automated the bisect with git bisect run ./bisect.sh and

bisect.sh
#!/bin/sh
git describe --tags
autoreconf -ivf || exit 128
mkdir -p build
cd build
../configure && make -j10 || exit 128

LD_LIBRARY_PATH=libusb/.libs ldd /bin/lsusb | grep -F .libs || { echo "Bad!"; exit 128; }
out=$(LD_LIBRARY_PATH=libusb/.libs lsusb)
echo "$out"
echo .
echo "$out" | grep Apple

Further info:

@dickens
Copy link
Member

dickens commented Dec 26, 2020

This was fixed in f6d2cb5. Refer to #825

@dickens dickens closed this as completed Dec 26, 2020
@mcuee mcuee added the linux label Dec 27, 2020
@Lekensteyn
Copy link
Author

Thank you! I could confirm that the issue was fixed on git master, but after switching branches I accidentally forgot to rebuild libusb.

Happy holidays! 🎉

@mcuee mcuee added this to the 1.0.25 milestone Jan 13, 2021
yorickvP added a commit to yorickvP/nixpkgs that referenced this issue Feb 6, 2021
Both arch and debian apply this same patch. Resolves the issue at
libusb/libusb#831 .
jtojnar pushed a commit to NixOS/nixpkgs that referenced this issue Feb 7, 2021
Both arch and debian apply this same patch. Resolves the issue at
libusb/libusb#831.
dasj19 pushed a commit to dasj19/nixpkgs that referenced this issue Feb 11, 2021
Both arch and debian apply this same patch. Resolves the issue at
libusb/libusb#831.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants