configure.ac: link with -latomic if needed #1064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libusb unconditionally uses atomic_fetch_add since version 1.0.25 and 1a08aa8 eed8a37 but some architectures (e.g. sparc) needs to link with -latomic to be able to use it. So check if -latomic is needed and update libusb-1.0.pc accordingly to avoid the following build failure with openocd: /home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/10.3.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: /home/buildroot/autobuild/instance-0/output-1/host/sparc-buildroot-linux-uclibc/sysroot/usr/lib/libusb-1.0.so: undefined reference to `__atomic_fetch_add_4' collect2: error: ld returned 1 exit status Fixes: - http://autobuild.buildroot.org/results/4a27a769bb3cdf78643c3049b87d792178d6512c Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
Sound good but what OS and build environment versions etc is this? It builds without -latomic on sparc64 here: https://buildd.debian.org/status/fetch.php?pkg=libusb-1.0&arch=sparc64&ver=2%3A1.0.25-1&stamp=1644184820&raw=0 |
|
I'm using buildroot and build fails on sparc v8 (http://autobuild.buildroot.org/results/4a2/4a27a769bb3cdf78643c3049b87d792178d6512c/config) |
tormodvolden
pushed a commit
to tormodvolden/libusb
that referenced
this pull request
Mar 15, 2022
libusb unconditionally uses atomic_fetch_add since version 1.0.25 and commit 1a08aa8 and commit eed8a37 but some architectures (e.g. sparc) needs to link with -latomic to be able to use it. So check if -latomic is needed and update libusb-1.0.pc accordingly to avoid the following build failure with openocd: /home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/10.3.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: /home/buildroot/autobuild/instance-0/output-1/host/sparc-buildroot-linux-uclibc/sysroot/usr/lib/libusb-1.0.so: undefined reference to `__atomic_fetch_add_4' collect2: error: ld returned 1 exit status Full build log: http://autobuild.buildroot.org/results/4a27a769bb3cdf78643c3049b87d792178d6512c Closes libusb#1064 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libusb unconditionally uses
atomic_fetch_addsince version 1.0.25 (1a08aa8 and eed8a37) but some architectures (e.g. sparc) needs to link with-latomicto be able to use it. So check if-latomicis needed and updatelibusb-1.0.pcaccordingly to avoid the following build failure with openocd:Fixes:
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com