windows: Link gcc helpers statically on MinGW #1068
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been tested to do what it should, only add -static-libgcc to the linker flags when building the final libusb.dll on MinGW. There are however an infinite number of ways to do this with autoconf, so style and consistency could be reviewed. I am adding EXTRA_LDFLAGS instead of using (abusing?) LT_LDFLAGS which I suspect is used for non-libtool flags some other places. OTOH for instance EXTRA_CFLAGS is only used locally in configure.ac and put into AM_CFLAGS directly. I am not using AM_LDFLAGS if that is a thing, and I think that is fine since the extra flag should only be applied to the DLL linking. Maybe a more specific variable name could be used.