Second attempt to fix #1263 by acquiring the waiters during transfer callback and reordering sync_transfer_cb. #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…callbacks and swapping the order of operations in sync_transfer_cb
|
Going to merge this. Hoping to get reviews on a couple of PRs then we will be good to start the RC process. |
|
Thanks @Erlkoenig90 , it looks good to me |
sonatique
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, this PR replaces #1264 to fix #1263 and should properly fix the race condition by using a synchronization primitive (mutex) instead of solely relying on the order of operations on memory within
sync_transfer_cb, which is not guaranteed by the language.