Match any device in hotplugtest by default #1350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I spent some time trying to figure out why, when I run this example, it's not showing any events, until I looked into the code and saw it has some hardcoded vid:pid. Most people probably don't have the specific device hardcoded here, and it seems better to default to showing events for any device unless overridden. While at it, also updated device detached message to match the attached one to show vid:pid.
|
Thanks, I also think this makes sense. While at it, I added some error string printing, which I noticed was missing when I tested this. |
|
It would be good to apply the patch from @sonatique in the above discussion. Reason: |
@mcuee would you like me to make a sperate PR with just this patch? |
Yes, I think that is a good idea. Thanks. |
|
Somehow I think this PR is flawed for Linux. It kind of leads to unpredicatble results. Please refer to the test results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time trying to figure out why, when I run this example, it's not showing any events, until I looked into the code and saw it has some hardcoded vid:pid.
Most people probably don't have the specific device hardcoded here, and it seems better to default to showing events for any device unless overridden.
While at it, also updated device detached message to match the attached one to show vid:pid.